Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31459 )
Change subject: google/mistral: Setup required Chromeos GPIOs. ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/31459/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@7 PS2, Line 7: google/mistral: Setup required Chromeos GPIOs. 1. The verb *set up* is spelled with a space. 2. Please remove the dot at the end of the commit message summary.
https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@9 PS2, Line 9: Setup Set up
https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@10 PS2, Line 10: requires required
https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@9 PS2, Line 9: etup Flash write protect, recovery and h1 interrupt : gpios to requires state at boot. Where is it documented, what is required?
https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@13 PS2, Line 13: functionalities How?