Change in ...coreboot[master]: google/mistrtal: Setup required Chromeos GPIOs.

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

SANTHOSH JANARDHANA HASSAN (Code Review)

18 Feb 2019 18 Feb '19

7:20 a.m.

SANTHOSH JANARDHANA HASSAN has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31459

Change subject: google/mistrtal: Setup required Chromeos GPIOs. ......................................................................

google/mistrtal: Setup required Chromeos GPIOs.

Setup Flash write protect, recovery and h1 interrupt gpios to requires state at boot.

BUG=None TEST=Verified GPIO state and its functionalities. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/1

diff --git a/src/mainboard/google/mistral/bootblock.c b/src/mainboard/google/mistral/bootblock.c index 6718d52..c72856d 100644 --- a/src/mainboard/google/mistral/bootblock.c +++ b/src/mainboard/google/mistral/bootblock.c @@ -15,8 +15,9 @@

#include <bootblock_common.h> #include <timestamp.h> +#include "board.h"

void bootblock_mainboard_init(void) { - + setup_chromeos_gpios(); }

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

SANTHOSH JANARDHANA HASSAN (Code Review)

18 Feb 18 Feb

7:21 a.m.

New subject: Change in ...coreboot[master]: google/mistral: Setup required Chromeos GPIOs.

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31459

to look at the new patch set (#2).

Change subject: google/mistral: Setup required Chromeos GPIOs. ......................................................................

google/mistral: Setup required Chromeos GPIOs.

Setup Flash write protect, recovery and h1 interrupt gpios to requires state at boot.

BUG=None TEST=Verified GPIO state and its functionalities. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/2

Paul Menzel (Code Review)

1:39 p.m.

New subject: Change in ...coreboot[master]: google/mistral: Setup required Chromeos GPIOs.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31459 )

Change subject: google/mistral: Setup required Chromeos GPIOs. ......................................................................

Patch Set 2:

(5 comments)

https://review.coreboot.org/#/c/31459/2//COMMIT_MSG Commit Message:

https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@7 PS2, Line 7: google/mistral: Setup required Chromeos GPIOs. 1. The verb *set up* is spelled with a space. 2. Please remove the dot at the end of the commit message summary.

https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@9 PS2, Line 9: Setup Set up

https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@10 PS2, Line 10: requires required

https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@9 PS2, Line 9: etup Flash write protect, recovery and h1 interrupt : gpios to requires state at boot. Where is it documented, what is required?

https://review.coreboot.org/#/c/31459/2//COMMIT_MSG@13 PS2, Line 13: functionalities How?

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 2 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Mon, 18 Feb 2019 12:39:57 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

SANTHOSH JANARDHANA HASSAN (Code Review)

9 Mar 9 Mar

6:50 a.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 in...

Hello build bot (Jenkins), nsekar@codeaurora.org, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31459

to look at the new patch set (#6).

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt

Required for supporting hardware reset mechanism, protects SOC from voltage leak from H1.

BUG=None TEST=Verified hardware reset mechanism for SOC reset. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/6

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 6 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

14 Mar 14 Mar

4 p.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Setup required Chromeos GPIOs.

nsekar@codeaurora.org has uploaded a new patch set (#7) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31459 )

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Setup required Chromeos GPIOs. ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Setup required Chromeos GPIOs.

Setup Flash write protect, recovery and h1 interrupt gpios to requires state at boot.

BUG=None TEST=Verified GPIO state and its functionalities. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/7

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 7 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Name of user not set (Code Review)

20 Mar 20 Mar

1:47 p.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 in...

nsekar@codeaurora.org has uploaded a new patch set (#8) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31459 )

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt

Required for supporting hardware reset mechanism, protects SOC from voltage leak from H1.

BUG=None TEST=Verified hardware reset mechanism for SOC reset. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 8 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

10 Apr 10 Apr

8:47 p.m.

New subject: Change in ...coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 in...

Patrick Georgi has uploaded a new patch set (#11) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31459 )

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt

Required for supporting hardware reset mechanism, protects SOC from voltage leak from H1.

BUG=None TEST=Verified hardware reset mechanism for SOC reset. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/11

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 11 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: nsekar@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

19 Jul 19 Jul

12:44 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 in...

Patrick Georgi has uploaded a new patch set (#15) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31459 )

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt

Required for supporting hardware reset mechanism, protects SOC from voltage leak from H1.

BUG=None TEST=Verified hardware reset mechanism for SOC reset. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/15

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 15 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

24 Jul 24 Jul

9:39 p.m.

New subject: Change in coreboot[master]: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 in...

Patrick Georgi has uploaded a new patch set (#17) to the change originally created by SANTHOSH JANARDHANA HASSAN. ( https://review.coreboot.org/c/coreboot/+/31459 )

Change subject: TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt ......................................................................

TEMP: NOT FOR REVIEW: google/mistral: Enable internal pullup on H1 interrupt

Required for supporting hardware reset mechanism, protects SOC from voltage leak from H1.

BUG=None TEST=Verified hardware reset mechanism for SOC reset. BRANCH=None

Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Signed-off-by: Santhosh Hassan sahassan@google.com --- M src/mainboard/google/mistral/bootblock.c 1 file changed, 2 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/59/31459/17

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 17 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

11 Mar 11 Mar

4:23 p.m.

New subject: Change in coreboot[master]: google/mistral: Enable internal pullup on H1 interrupt

Patrick Georgi has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/31459 )

Change subject: google/mistral: Enable internal pullup on H1 interrupt ......................................................................

Abandoned

won't be finished here

-- To view, visit https://review.coreboot.org/c/coreboot/+/31459 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I5d98737a3b4e6376fd1c7115c42e795bba3b56ef Gerrit-Change-Number: 31459 Gerrit-PatchSet: 26 Gerrit-Owner: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: Nitheesh Sekar nsekar@codeaurora.org Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: SANTHOSH JANARDHANA HASSAN sahassan@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: abandon

1501

days inactive

1888

days old

coreboot-gerrit@coreboot.org

9 comments

4 participants

tags (0)

participants (4)

Name of user not set (Code Review)
Patrick Georgi (Code Review)
Paul Menzel (Code Review)
SANTHOSH JANARDHANA HASSAN (Code Review)