Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35289 )
Change subject: [WIP] intel/fsp2_0: Restrict references to CAR ......................................................................
Patch Set 2:
Patch Set 2:
Subrata; the motivation is that AMD Picasso will use some of the FSP2.x infrastructure for the UEFI abstractions/API it provides. Not optimal, but apparently the most straight-forward choice given the layout of AMD vendorcode.
For this change, the motivation is to be able to build the file such that _car_xxx symbol references will hit garbage collection. Implementation of amd/picasso runs with romstage already in DRAM.
My understanding is Picasso needs FSP-M loader but without the actual raminit call here. Marshall or Martin should comment on that further. The attempt is to reorganise code here such that it is not necessary to initialize memranges at all.
Thanks for adding me, let me talk a look as well