[coreboot-gerrit] Change in coreboot[master]: mb/acer: Add Acer Aspire VN7-572G

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )

Change subject: mb/acer: Add Acer Aspire VN7-572G
......................................................................

Patch Set 169:

(1 comment)

https://review.coreboot.org/c/coreboot/+/35523/165/src/mainboard/acer/aspire... 
File src/mainboard/acer/aspire_vn7_572g/gpio.h:

PS165:
> What's the objective?

It is fundamentally wrong. If any of the definitions below is used in more than one compilation unit, there will be multiple copies of the same data in the final coreboot.rom. If each definition is used in exactly one compilation unit, the definitions can instead be placed directly into the corresponding compilation unit, and this header becomes unnecessary.