Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39830 )
Change subject: libpayload/x86: Try to discover invariant TSC rate ......................................................................
Patch Set 2:
(6 comments)
https://review.coreboot.org/c/coreboot/+/39830/1/payloads/libpayload/arch/x8... File payloads/libpayload/arch/x86/timer.c:
https://review.coreboot.org/c/coreboot/+/39830/1/payloads/libpayload/arch/x8... PS1, Line 87: */ In case of error return `-1`.
https://review.coreboot.org/c/coreboot/+/39830/1/payloads/libpayload/arch/x8... PS1, Line 95: return -1; Why not have this check in `get_cpu_khz_fast`?
https://review.coreboot.org/c/coreboot/+/39830/1/payloads/libpayload/arch/x8... PS1, Line 100: SandyBridge Sandy Bridge
https://review.coreboot.org/c/coreboot/+/39830/1/payloads/libpayload/arch/x8... PS1, Line 101: IvyBridge Ivy Bridge
https://review.coreboot.org/c/coreboot/+/39830/1/payloads/libpayload/arch/x8... PS1, Line 107: return -1; Add a debug message for the default case?
https://review.coreboot.org/c/coreboot/+/39830/1/payloads/libpayload/arch/x8... PS1, Line 128: if (cpu_khz_fast > 0) As 0 is regarded also an error, I’d use `unsigned int` as return values and treat 0 as error.