6 comments:
File payloads/libpayload/arch/x86/timer.c:
In case of error return `-1`.
Patch Set #1, Line 95: return -1;
Why not have this check in `get_cpu_khz_fast`?
Patch Set #1, Line 100: SandyBridge
Sandy Bridge
Patch Set #1, Line 101: IvyBridge
Ivy Bridge
Patch Set #1, Line 107: return -1;
Add a debug message for the default case?
Patch Set #1, Line 128: if (cpu_khz_fast > 0)
As 0 is regarded also an error, I’d use `unsigned int` as return values and treat 0 as error.
To view, visit change 39830. To unsubscribe, or for help writing mail filters, visit settings.