Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45316 )
Change subject: src: Add missing <device/pnp_def.h> ......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/45316/1/src/include/device/pnp.h File src/include/device/pnp.h:
https://review.coreboot.org/c/coreboot/+/45316/1/src/include/device/pnp.h@a6 PS1, Line 6: #include <device/pnp_def.h> I'm not really sure if removing this here is a good idea or not. The main question there is if device/pnp.h should be a meta-include for all pnp-related stuff or not. On one hand i dislike too indirect includes and prefer direct includes, but on the other hand having too many includes for the same area of things adds a bit noise.