Patch set 1:Code-Review +1

View Change

1 comment:

• File src/include/device/pnp.h:

  • Patch Set #1, Line 6: #include <device/pnp_def.h>

    I'm not really sure if removing this here is a good idea or not. The main question there is if device/pnp.h should be a meta-include for all pnp-related stuff or not. On one hand i dislike too indirect includes and prefer direct includes, but on the other hand having too many includes for the same area of things adds a bit noise.

To view, visit change 45316. To unsubscribe, or for help writing mail filters, visit settings.