Attention is currently required from: Jamie Ryu, Sugnan Prabhu S. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46819 )
Change subject: soc/intel/common: Move reset request into intel_fw_update ......................................................................
Patch Set 8:
(6 comments)
File src/soc/intel/alderlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/46819/comment/bc330ca9_25e1b383 PS8, Line 139: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) || CONFIG(INTEL_TOP_SWAP_MULTI_FIT_UCODE_UPDATE)) line over 96 characters
File src/soc/intel/common/basecode/fw_update/ucode_update.c:
https://review.coreboot.org/c/coreboot/+/46819/comment/860a9123_a447f98e PS8, Line 252: printk(BIOS_INFO, "ucode: recovery mode enabled\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/46819/comment/3061f5a8_e5fcc9b2 PS8, Line 252: printk(BIOS_INFO, "ucode: recovery mode enabled\n"); please, no space before tabs
https://review.coreboot.org/c/coreboot/+/46819/comment/ad26dbc2_f33a2767 PS8, Line 252: printk(BIOS_INFO, "ucode: recovery mode enabled\n"); please, no spaces at the start of a line
File src/soc/intel/jasperlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/46819/comment/2492e261_932ba4b3 PS8, Line 147: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) || CONFIG(INTEL_TOP_SWAP_MULTI_FIT_UCODE_UPDATE)) line over 96 characters
File src/soc/intel/tigerlake/romstage/romstage.c:
https://review.coreboot.org/c/coreboot/+/46819/comment/a5f102c9_d9613569 PS8, Line 146: if (CONFIG(SOC_INTEL_CSE_LITE_SKU) || CONFIG(INTEL_TOP_SWAP_MULTI_FIT_UCODE_UPDATE)) line over 96 characters