Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37115 )
Change subject: sb/intel/bd82x6x: Support ME Soft Temporary Disable Mode ......................................................................
Patch Set 8:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... File src/southbridge/intel/bd82x6x/me_8.x.c:
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 535: } could be:
{ set_global_reset(1); full_reset(); }
The former would have to be exported.
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 537: enable How about naming this *enter*_soft_temp_disable_mode() and the other *exit*?
https://review.coreboot.org/c/coreboot/+/37115/5/src/southbridge/intel/bd82x... PS5, Line 774: if (me_disable) { I would prefer to only act if `me_disable_prev` differs. If both are 1, we tried before and failed. Probably not a good idea to try again and skip the reset.