View Change

3 comments:

• File src/southbridge/intel/bd82x6x/me_8.x.c:

  • Patch Set #5, Line 535: }

    could be:

        {
                set_global_reset(1);
                full_reset();
        }

    The former would have to be exported.

  • Patch Set #5, Line 537: enable

    How about naming this *enter*_soft_temp_disable_mode() and the other *exit*?

  • Patch Set #5, Line 774: if (me_disable) {

    I would prefer to only act if `me_disable_prev` differs. If both are 1,
    we tried before and failed. Probably not a good idea to try again and
    skip the reset.

To view, visit change 37115. To unsubscribe, or for help writing mail filters, visit settings.