[coreboot-gerrit] Change in coreboot[master]: herobrine: SoC makefile blob support

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47074 )

Change subject: herobrine: SoC makefile blob support
......................................................................

Patch Set 1:

(4 comments)

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@9 
PS1, Line 9:     Following blobs will includes with SoC makefile:
Please remove the indentation (probably copied from `git show` output for some reason).

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@9 
PS1, Line 9: will includes
are included

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@10 
PS1, Line 10: QCSEC
I do not see that in the diff of the Makefile.

https://review.coreboot.org/c/coreboot/+/47074/1//COMMIT_MSG@11 
PS1, Line 11:       * QUPV3FW
Please describe boths blobs in the commit message.