Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32112 )
Change subject: bootmode: display_init_required() to check VBOOT and OPROM_MATTERS ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/32112/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/32112/1//COMMIT_MSG@7 PS1, Line 7: bootmode: display_init_required() to check VBOOT and OPROM_MATTERS
Statement please: […]
There's only so much I can fit on one line when the function name already takes up half of it. Suggestions welcome but I couldn't come up with anything that doesn't drop substance in favor of grammar nitpicks.
https://review.coreboot.org/#/c/32112/1//COMMIT_MSG@14 PS1, Line 14: VBOOT_OPROM_MATTERS
Prefix with CONFIG_ as done in the paragraph above?
Sure, will do.