View Change
2 comments:
Commit Message:
Patch Set #1, Line 7: bootmode: display_init_required() to check VBOOT and OPROM_MATTERS
Statement please: […]
There's only so much I can fit on one line when the function name already takes up half of it. Suggestions welcome but I couldn't come up with anything that doesn't drop substance in favor of grammar nitpicks.
Patch Set #1, Line 14: VBOOT_OPROM_MATTERS
Prefix with CONFIG_ as done in the paragraph above?
Sure, will do.
To view, visit change 32112. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5d6421509bdcdaa61b78015af3fa6241fe75bb7f
Gerrit-Change-Number: 32112
Gerrit-PatchSet: 2
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Thu, 28 Mar 2019 21:40:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: comment