Máté Kukri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43087 )
Change subject: mb/bostentech: Add GBYT4 port ......................................................................
Patch Set 17:
(10 comments)
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/Kconfig File src/mainboard/unk/Kconfig:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/Kconfig@1 PS1, Line 1: UNK
I'd use "unknown" in symbol and folder names, it's clearer
Proper vendor name was added instead.
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/acp... File src/mainboard/unk/gbyt4/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/acp... PS1, Line 3: Scope (_SB.PCI0.LPEA)
I can delete the GpioInt lines but the ResourceTemplate needs to remain otherwise it doesn't build.
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/cmo... File src/mainboard/unk/gbyt4/cmos.layout:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/cmo... PS1, Line 12: #96 4 r 0 status_c_rsvd
I will drop them. […]
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... File src/mainboard/unk/gbyt4/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dev... PS1, Line 12: 0x1
I will change it to 3, just the comment i copied along with the base device tree from rambi (incorre […]
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dsd... File src/mainboard/unk/gbyt4/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dsd... PS1, Line 22: Scope (_SB) { : Device (PCI0) : {
Ugh, that inconsistent brace placement... […]
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dsd... PS1, Line 25: //#include <soc/intel/baytrail/acpi/northcluster.asl>
You can drop this commented-out include
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dsd... PS1, Line 27: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
If your board doesn't have an integrated LCD, this can be removed
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dsd... PS1, Line 31: #include "acpi/dptf.asl"
Since DPTF is not enabled, you can drop this and remove the file
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/dsd... PS1, Line 35: #include "acpi/mainboard.asl"
If this file is empty, you can remove this line
Done
https://review.coreboot.org/c/coreboot/+/43087/1/src/mainboard/unk/gbyt4/ear... File src/mainboard/unk/gbyt4/early_init.c:
PS1:
I am not sure if this code is being called... To be sure, you can move this to romstage. […]
Serial only works properly in bootblock, if it's called here.