10 comments:
File src/mainboard/unk/Kconfig:
I'd use "unknown" in symbol and folder names, it's clearer
Proper vendor name was added instead.
File src/mainboard/unk/gbyt4/acpi/mainboard.asl:
Patch Set #1, Line 3: Scope (\_SB.PCI0.LPEA)
I can delete the GpioInt lines but the ResourceTemplate needs to remain otherwise it doesn't build.
Done
File src/mainboard/unk/gbyt4/cmos.layout:
Patch Set #1, Line 12: #96 4 r 0 status_c_rsvd
I will drop them. […]
Done
File src/mainboard/unk/gbyt4/devicetree.cb:
I will change it to 3, just the comment i copied along with the base device tree from rambi (incorre […]
Done
File src/mainboard/unk/gbyt4/dsdt.asl:
Scope (\_SB) {
Device (PCI0)
{
Ugh, that inconsistent brace placement... […]
Done
Patch Set #1, Line 25: //#include <soc/intel/baytrail/acpi/northcluster.asl>
You can drop this commented-out include
Done
Patch Set #1, Line 27: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
If your board doesn't have an integrated LCD, this can be removed
Done
Patch Set #1, Line 31: #include "acpi/dptf.asl"
Since DPTF is not enabled, you can drop this and remove the file
Done
Patch Set #1, Line 35: #include "acpi/mainboard.asl"
If this file is empty, you can remove this line
Done
File src/mainboard/unk/gbyt4/early_init.c:
I am not sure if this code is being called... To be sure, you can move this to romstage. […]
Serial only works properly in bootblock, if it's called here.
To view, visit change 43087. To unsubscribe, or for help writing mail filters, visit settings.