Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34771 )
Change subject: soc/mediatek: dsi: Refactor PHY timing calculation ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34771/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34771/6//COMMIT_MSG@9 PS6, Line 9: calculate calculated
https://review.coreboot.org/c/coreboot/+/34771/6/src/soc/mediatek/common/dsi... File src/soc/mediatek/common/dsi.c:
https://review.coreboot.org/c/coreboot/+/34771/6/src/soc/mediatek/common/dsi... PS6, Line 100: timcon0 = phy_timing->lpx | phy_timing->da_hs_prepare << 8 | : phy_timing->da_hs_zero << 16 | phy_timing->da_hs_trail << 24; Does it make sense to define a macro similar to the following? Then much code under soc/mediatek can be simplified.
#define STRING_TO_UINT32(a, b, c, d) ((UINT32) ((d << 24) | (c << 16) | (b << 8) | a))
(from in amd/agesa/f16kb/Proc/GNB/Common/Gnb.h)