View Change

2 comments:

• Commit Message:

  • Patch Set #6, Line 9: calculate

    calculated

• File src/soc/mediatek/common/dsi.c:

  • Patch Set #6, Line 100:

    timcon0 = phy_timing->lpx | phy_timing->da_hs_prepare << 8 |
    		  phy_timing->da_hs_zero << 16 | phy_timing->da_hs_trail << 24;
    

    Does it make sense to define a macro similar to the following? Then much code under soc/mediatek can be simplified.

    #define STRING_TO_UINT32(a, b, c, d) ((UINT32) ((d << 24) | (c << 16) | (b << 8) | a))

    (from in amd/agesa/f16kb/Proc/GNB/Common/Gnb.h)

To view, visit change 34771. To unsubscribe, or for help writing mail filters, visit settings.