Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31206 )
Change subject: Kconfig: Add system type entries for convertible and tablet ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31206/1/src/Kconfig File src/Kconfig:
https://review.coreboot.org/#/c/31206/1/src/Kconfig@334 PS1, Line 334: config SYSTEM_TYPE_LAPTOP
I thought about that but is choice meant to have user-visible options? […]
Okay, good point. IIRC there's no real way to put any restrictions on Kconfig 'select', so making this a choice probably wouldn't help either. So it's probably best to do it like you have here.
A way we've guaranteed mutual exclusion between 'select'able options in the past is with _Static_assert()s in C code, like in src/security/vboot/vboot_loader.c. Could do that here, although I'm not sure if it's important enough to care.