Patch set 2:Code-Review +2
View Change
1 comment:
File src/Kconfig:
Patch Set #1, Line 334: config SYSTEM_TYPE_LAPTOP
I thought about that but is choice meant to have user-visible options? […]
Okay, good point. IIRC there's no real way to put any restrictions on Kconfig 'select', so making this a choice probably wouldn't help either. So it's probably best to do it like you have here.
A way we've guaranteed mutual exclusion between 'select'able options in the past is with _Static_assert()s in C code, like in src/security/vboot/vboot_loader.c. Could do that here, although I'm not sure if it's important enough to care.
To view, visit change 31206. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I148ec2329a1dd38ad55c60ba277a514c66376fcc
Gerrit-Change-Number: 31206
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Duncan Laurie <dlaurie@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 01 Feb 2019 22:56:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Julius Werner <jwerner@chromium.org>
Comment-In-Reply-To: Duncan Laurie <dlaurie@chromium.org>
Gerrit-MessageType: comment