Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45854 )
Change subject: mb/google/zork: Initialize the backlight in the OS
......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/45854/4/src/mainboard/google/zork/s...
File src/mainboard/google/zork/smihandler.c:
https://review.coreboot.org/c/coreboot/+/45854/4/src/mainboard/google/zork/s...
PS4, Line 38: gpio_set(GPIO_85, 0);
Maybe the following if I understand your intent
if (apmc == APM_CNT_ACPI_ENABLE)
gpio_set(GPIO_85, 0);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45854
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ecc3c9e397c9756a78e480d3f639c507879a0ea
Gerrit-Change-Number: 45854
Gerrit-PatchSet: 5
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Peers
epeers@google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Rob Barnes
robbarnes@google.com
Gerrit-Comment-Date: Wed, 30 Sep 2020 19:53:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment