Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... PS2, Line 16: #include <console/console.h> Nit: nothing is going towards console at this point. So may be remove including the header file for now and include it when required?