Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
soc/intel/tigerlake: Include soc common lpss header file
Change-Id: I2b2c82fc7592120993bc483d3061803cf75c7335 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/fsp_params.c 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/37556/1
diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index 18985a6..c953c95 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -15,6 +15,7 @@
#include <console/console.h> #include <fsp/api.h> +#include <intelblocks/lpss.h> #include <soc/ramstage.h>
static const pci_devfn_t serial_io_dev[] = {
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... PS2, Line 16: #include <console/console.h> Nit: nothing is going towards console at this point. So may be remove including the header file for now and include it when required?
Hello Patrick Rudolph, Subrata Banik, Wonkyu Kim, Maulik V Vaghela, Rizwan Qureshi, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37556
to look at the new patch set (#3).
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
soc/intel/tigerlake: Include soc common lpss header file
Include soc common lpss header file and also remove console header since it is unused.
Change-Id: I2b2c82fc7592120993bc483d3061803cf75c7335 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/37556/3
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... PS2, Line 16: #include <console/console.h>
Nit: nothing is going towards console at this point. […]
Ok, Removed
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/2/src/soc/intel/tigerlake/fsp... PS2, Line 16: #include <console/console.h>
Ok, Removed
Done
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... PS3, Line 17: #include <intelblocks/lpss.h> Is this include required related to other modification? (No other change in file)
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... PS3, Line 17: #include <intelblocks/lpss.h>
Is this include required related to other modification? […]
No, This was required for the build to go through soc_lpss_controllers_list is declared in common soc block
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... PS3, Line 17: #include <intelblocks/lpss.h>
No, This was required for the build to go through soc_lpss_controllers_list is declared in common so […]
comment did not mention build errors.
Hello Patrick Rudolph, Karthik Ramasubramanian, Subrata Banik, Wonkyu Kim, Maulik V Vaghela, Rizwan Qureshi, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37556
to look at the new patch set (#4).
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
soc/intel/tigerlake: Include soc common lpss header file
Include soc common lpss header file to resolve build error due to missing soc_lpss_controllers_list declaration.
Also remove console header since it is unused.
Change-Id: I2b2c82fc7592120993bc483d3061803cf75c7335 Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/soc/intel/tigerlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/37556/4
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 4: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/37556/3/src/soc/intel/tigerlake/fsp... PS3, Line 17: #include <intelblocks/lpss.h>
comment did not mention build errors.
Done
Maulik V Vaghela has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
Patch Set 4: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37556 )
Change subject: soc/intel/tigerlake: Include soc common lpss header file ......................................................................
soc/intel/tigerlake: Include soc common lpss header file
Include soc common lpss header file to resolve build error due to missing soc_lpss_controllers_list declaration.
Also remove console header since it is unused.
Change-Id: I2b2c82fc7592120993bc483d3061803cf75c7335 Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37556 Reviewed-by: Frans Hendriks fhendriks@eltan.com Reviewed-by: Maulik V Vaghela maulik.v.vaghela@intel.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/tigerlake/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Maulik V Vaghela: Looks good to me, approved Frans Hendriks: Looks good to me, but someone else must approve Karthik Ramasubramanian: Looks good to me, approved
diff --git a/src/soc/intel/tigerlake/fsp_params.c b/src/soc/intel/tigerlake/fsp_params.c index 18985a6..6fb2f9f 100644 --- a/src/soc/intel/tigerlake/fsp_params.c +++ b/src/soc/intel/tigerlake/fsp_params.c @@ -13,8 +13,8 @@ * GNU General Public License for more details. */
-#include <console/console.h> #include <fsp/api.h> +#include <intelblocks/lpss.h> #include <soc/ramstage.h>
static const pci_devfn_t serial_io_dev[] = {
-
Aamir Bohra (Code Review) -
Frans Hendriks (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Maulik V Vaghela (Code Review)
-
Patrick Georgi (Code Review)