Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48340 )
Change subject: soc/intel/alderlake: Revise PCIE port config
......................................................................
Patch Set 34:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48340/34/src/soc/intel/alderlake/ch...
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/48340/34/src/soc/intel/alderlake/ch...
PS34, Line 343: tic inline int pcie_is_flag_enabled(const struct pcie_rp_config pcie_rp,
: enum pcie_rp_flags flag_mask)
: {
: return pcie_rp.flags & flag_mask ? 1 : 0;
: }
:
not soc-specific
https://review.coreboot.org/c/coreboot/+/48340/28/src/soc/intel/alderlake/ro...
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/48340/28/src/soc/intel/alderlake/ro...
PS28, Line 157: CONFIG_MAX_ROOT_PORTS
We plan to add new Kconfig for CPU_RP ports. It would be different size though. […]
ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48340
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b390e43f8e99b19cfad178139b86a2f77d7a57b
Gerrit-Change-Number: 48340
Gerrit-PatchSet: 34
Gerrit-Owner: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 31 Dec 2020 11:46:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment