[coreboot-gerrit] Change in coreboot[master]: drivers: Replace multiple fill_lb_framebuffer with single instance

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39003 )

Change subject: drivers: Replace multiple fill_lb_framebuffer with single instance
......................................................................

Patch Set 18:

(4 comments)

https://review.coreboot.org/c/coreboot/+/39003/18/src/drivers/intel/gma/gma-... 
File src/drivers/intel/gma/gma-gfx_init.ads:

https://review.coreboot.org/c/coreboot/+/39003/18/src/drivers/intel/gma/gma-... 
PS18, Line 22:       return Interfaces.C.size_t;
`Interfaces.C.long` preferred, as we already assume that `long int` and pointers have the
same size.

https://review.coreboot.org/c/coreboot/+/39003/18/src/drivers/intel/gma/hire... 
File src/drivers/intel/gma/hires_fb/gma-gfx_init.adb:

https://review.coreboot.org/c/coreboot/+/39003/18/src/drivers/intel/gma/hire... 
PS18, Line 27:       use type word32;
`use type Interfaces.C.long;` to allow the comparison without a cast.

https://review.coreboot.org/c/coreboot/+/39003/18/src/drivers/intel/gma/hire... 
PS18, Line 83:                if (linear_fb_addr /= 0) then
No parentheses needed around the condition.

https://review.coreboot.org/c/coreboot/+/39003/18/src/drivers/intel/gma/hire... 
PS18, Line 89:                                  bits_per_pixel => 32);
Preferably indented by 3, ignoring the opening parthesis:

fbinfo := c_fb_add_framebuffer_info
      (fb_addr        => ...
       x_resolution   => ...

This way all identifiers align.