4 comments:
File src/drivers/intel/gma/gma-gfx_init.ads:
Patch Set #18, Line 22: return Interfaces.C.size_t;
`Interfaces.C.long` preferred, as we already assume that `long int` and pointers have the
same size.
File src/drivers/intel/gma/hires_fb/gma-gfx_init.adb:
Patch Set #18, Line 27: use type word32;
`use type Interfaces.C.long;` to allow the comparison without a cast.
Patch Set #18, Line 83: if (linear_fb_addr /= 0) then
No parentheses needed around the condition.
Patch Set #18, Line 89: bits_per_pixel => 32);
Preferably indented by 3, ignoring the opening parthesis:
fbinfo := c_fb_add_framebuffer_info
(fb_addr => ...
x_resolution => ...
This way all identifiers align.
To view, visit change 39003. To unsubscribe, or for help writing mail filters, visit settings.