Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37996 )
Change subject: soc/mediatek/mt8183: add TX tracking for DRAM DVFS ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... File src/soc/mediatek/mt8183/dramc_pi_calibration_api.c:
https://review.coreboot.org/c/coreboot/+/37996/8/src/soc/mediatek/mt8183/dra... PS8, Line 25: extern const u8 freq_shuffle[DRAM_DFS_SHUFFLE_MAX]; : extern const u8 freq_shuffle_emcp[DRAM_DFS_SHUFFLE_MAX]; : extern const u32 frequency_table[LP4X_DDRFREQ_MAX]; Please pass these as function arguments (for example, https://review.coreboot.org/c/coreboot/+/36286 ), or at least pack them into a struct.