Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47287 )
Change subject: WIP: load spm firmware from cbfs ......................................................................
Patch Set 8:
(13 comments)
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/inc... File src/soc/mediatek/mt8192/include/soc/spm.h:
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/inc... PS6, Line 673:
Remove extra blank line.
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 487: struct
const
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 496:
Remove the space.
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 570: 0x%x
%#x
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 573: 16
copy_size
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 581: struct pcm_desc
pcm->desc
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 582: &(pcm->desc.pmem_words)
Simply &pcm->desc
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 582: (void *)
No need for the casting.
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 587: spmfw version = %s and is
spmfw (version %s)
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 588: (
Remove the parentheses.
Done
https://review.coreboot.org/c/coreboot/+/47287/6/src/soc/mediatek/mt8192/spm... PS6, Line 709: 0x%x
%#x
Done
https://review.coreboot.org/c/coreboot/+/47287/8/src/soc/mediatek/mt8192/spm... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/47287/8/src/soc/mediatek/mt8192/spm... PS8, Line 12: ( No need for the parentheses.
https://review.coreboot.org/c/coreboot/+/47287/8/src/soc/mediatek/mt8192/spm... PS8, Line 583: SPMFW_HEADER_SIZE If this number is a constant, should we write
offset = SPMFW_HEADER_SIZE
instead?