13 comments:
File src/soc/mediatek/mt8192/include/soc/spm.h:
Remove extra blank line.
Done
File src/soc/mediatek/mt8192/spm.c:
Patch Set #6, Line 487: struct
const
Done
Remove the space.
Done
%#x
Done
copy_size
Done
Patch Set #6, Line 581: struct pcm_desc
pcm->desc
Done
Patch Set #6, Line 582: &(pcm->desc.pmem_words)
Simply &pcm->desc
Done
Patch Set #6, Line 582: (void *)
No need for the casting.
Done
Patch Set #6, Line 587: spmfw version = %s and is
spmfw (version %s)
Done
Remove the parentheses.
Done
%#x
Done
File src/soc/mediatek/mt8192/spm.c:
No need for the parentheses.
Patch Set #8, Line 583: SPMFW_HEADER_SIZE
If this number is a constant, should we write
offset = SPMFW_HEADER_SIZE
instead?
To view, visit change 47287. To unsubscribe, or for help writing mail filters, visit settings.