Attention is currently required from: Jonathan Zhang, weidong.wd@bytedance.com, Angel Pons, Arthur Heymans, TangYiwei, Andrey Petrov, Sean Rhodes, Tarun Tuli, Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Tim Wawrzynczak, Lean Sheng Tan, Werner Zeh, Tim Chu.
David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68525 )
Change subject: soc/intel: Add node_num to dimm_info struct + adjust dimm_info_fill
......................................................................
Patch Set 5:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/68525/comment/5648dc52_b513571a
PS3, Line 14: Furthermore, function dimm_info_fill()
: was adjusted.
How about: […]
Done
https://review.coreboot.org/c/coreboot/+/68525/comment/bd5881bb_727949fb
PS3, Line 17: ATLAS
nit: Mainboard Kconfig capitalizes only the first letter of `Atlas`
Done
https://review.coreboot.org/c/coreboot/+/68525/comment/86e304c8_8d82800d
PS3, Line 25: RVP board.
Maybe elaborate a bit more? […]
Done
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/68525/comment/2df7926f_e38e2965
PS4, Line 96: * Node-ID / Memory-Controller-ID
Yes, similar like on the server side, the hierarchy is socket/controller/channel/DIMM.
Done
File src/include/memory_info.h:
https://review.coreboot.org/c/coreboot/+/68525/comment/5aa2c90f_32846c58
PS3, Line 98: uint8_t node_num;
It's just a data struct, so there's no problem if the offsets change. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68525
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6ffa5bdff0ba0e3c4a4a51f2419291fd1278cd68
Gerrit-Change-Number: 68525
Gerrit-PatchSet: 5
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: TangYiwei
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Reviewer: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: weidong.wd@bytedance.com
Gerrit-Attention: Jonathan Zhang
jonzhang@fb.com
Gerrit-Attention: weidong.wd@bytedance.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: TangYiwei
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Tim Wawrzynczak
inforichland@gmail.com
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: Werner Zeh
werner.zeh@siemens.com
Gerrit-Attention: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Comment-Date: Wed, 02 Nov 2022 14:08:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jonathan Zhang
jonzhang@fb.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: David Milosevic
David.Milosevic@9elements.com
Gerrit-MessageType: comment