[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel: Add node_num to dimm_info struct + adjust dimm_info_fill

[David Milosevic (Code Review)]

Attention is currently required from: Jonathan Zhang, [e-mail], Angel Pons, Arthur Heymans, TangYiwei, Andrey Petrov, Sean Rhodes, Tarun Tuli, Anjaneya "Reddy" Chagam, Johnny Lin, Christian Walter, Tim Wawrzynczak, Lean Sheng Tan, Werner Zeh, Tim Chu.

David Milosevic has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68525 )

Change subject: soc/intel: Add node_num to dimm_info struct + adjust dimm_info_fill
......................................................................


Patch Set 5:

(5 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/68525/comment/5648dc52_b513571a 
PS3, Line 14: Furthermore, function dimm_info_fill()
            : was adjusted.
> How about: […]
> Done

https://review.coreboot.org/c/coreboot/+/68525/comment/bd5881bb_727949fb 
PS3, Line 17: ATLAS
> nit: Mainboard Kconfig capitalizes only the first letter of `Atlas`
> Done

https://review.coreboot.org/c/coreboot/+/68525/comment/86e304c8_8d82800d 
PS3, Line 25: RVP board.
> Maybe elaborate a bit more? […]
> Done

File src/include/memory_info.h:

https://review.coreboot.org/c/coreboot/+/68525/comment/2df7926f_e38e2965 
PS4, Line 96: 	 * Node-ID / Memory-Controller-ID
> Yes, similar like on the server side, the hierarchy is socket/controller/channel/DIMM.
> Done

File src/include/memory_info.h:

https://review.coreboot.org/c/coreboot/+/68525/comment/5aa2c90f_32846c58 
PS3, Line 98: 	uint8_t node_num;
> It's just a data struct, so there's no problem if the offsets change. […]
> Done