Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34484 )
Change subject: mb/google/hatch: Initialize SSD GPIOs in bootblock ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/34484/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34484/1//COMMIT_MSG@7 PS1, Line 7: GPIOs Did you identify which of these are really required to fix the 0x5a issue?
https://review.coreboot.org/c/coreboot/+/34484/1//COMMIT_MSG@16 PS1, Line 16: Run faft_bios Is the 0x5a issue resolved with this for Hatch?
https://review.coreboot.org/c/coreboot/+/34484/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/baseboard/gpio.c:
https://review.coreboot.org/c/coreboot/+/34484/1/src/mainboard/google/hatch/... PS1, Line 445: GPP_E4 Is this really required? It seems to be a wake pin?
https://review.coreboot.org/c/coreboot/+/34484/1/src/mainboard/google/hatch/... PS1, Line 447: GPP_E5 Does this matter for NVMe? It seems to be a SATA related pin. It might be required for SATA disks though.