View Change

4 comments:

• Commit Message:

  • Patch Set #1, Line 7: GPIOs

    Did you identify which of these are really required to fix the 0x5a issue?

  • Patch Set #1, Line 16: Run faft_bios

    Is the 0x5a issue resolved with this for Hatch?

• File src/mainboard/google/hatch/variants/baseboard/gpio.c:

  • Patch Set #1, Line 445: GPP_E4

    Is this really required? It seems to be a wake pin?

  • Patch Set #1, Line 447: GPP_E5

    Does this matter for NVMe? It seems to be a SATA related pin. It might be required for SATA disks though.

To view, visit change 34484. To unsubscribe, or for help writing mail filters, visit settings.