[coreboot-gerrit] Change in coreboot[master]: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41852 )

Change subject: sb/intel/bd82x6x/smihandler: Fix xHCI sleep handler
......................................................................

Patch Set 6: Code-Review-1

(1 comment)

definitely need to add smm_points_to_smram() checks for all of those random xhci_bar + ? reads

https://review.coreboot.org/c/coreboot/+/41852/6/src/southbridge/intel/bd82x... 
File src/southbridge/intel/bd82x6x/smihandler.c:

https://review.coreboot.org/c/coreboot/+/41852/6/src/southbridge/intel/bd82x... 
PS6, Line 116: 		if (!smm_points_to_smram((void *)(uintptr_t)xhci_bar)) {
> Shouldn't this check the actual addresses we are going to read?

Agreed, all 5 addresses should be checked.