Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39398 )
Change subject: mb/hp: Add Elitebook 8560w as an HP Sandy/Ivy Bridge laptop variant ......................................................................
Patch Set 1: Code-Review+1
(6 comments)
https://review.coreboot.org/c/coreboot/+/39398/1/Documentation/mainboard/hp/... File Documentation/mainboard/hp/8560w.md:
https://review.coreboot.org/c/coreboot/+/39398/1/Documentation/mainboard/hp/... PS1, Line 12: 8MB 8 MiB
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/8560w/early_init.c:
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... PS1, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2020 The coreboot project Authors. : * : * SPDX-License-Identifier: GPL-2.0-or-later : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/8560w/gpio.c:
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... PS1, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2020 The coreboot project Authors. : * : * SPDX-License-Identifier: GPL-2.0-or-later : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/8560w/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... PS1, Line 1: /* : * This file is part of the coreboot project. : * : * Copyright 2020 The coreboot project Authors. : * : * SPDX-License-Identifier: GPL-2.0-or-later : */ /* SPDX-License-Identifier: GPL-2.0-or-later */
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... File src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... PS1, Line 1: # : # This file is part of the coreboot project. : # : # Copyright 2020 The coreboot project Authors. : # : # SPDX-License-Identifier: GPL-2.0-or-later : # ## SPDX-License-Identifier: GPL-2.0-or-later
https://review.coreboot.org/c/coreboot/+/39398/1/src/mainboard/hp/snb_ivb_la... PS1, Line 26: end nit: align the `end` words?