Patch set 1:Code-Review +1

View Change

6 comments:

• File Documentation/mainboard/hp/8560w.md:

  • Patch Set #1, Line 12: 8MB

    8 MiB

• File src/mainboard/hp/snb_ivb_laptops/variants/8560w/early_init.c:

  • Patch Set #1, Line 1:

    /*
     * This file is part of the coreboot project.
     *
     * Copyright 2020 The coreboot project Authors.
     *
     * SPDX-License-Identifier: GPL-2.0-or-later
     */
    

    /* SPDX-License-Identifier: GPL-2.0-or-later */

• File src/mainboard/hp/snb_ivb_laptops/variants/8560w/gpio.c:

  • Patch Set #1, Line 1:

    /*
     * This file is part of the coreboot project.
     *
     * Copyright 2020 The coreboot project Authors.
     *
     * SPDX-License-Identifier: GPL-2.0-or-later
     */
    

    /* SPDX-License-Identifier: GPL-2.0-or-later */

• File src/mainboard/hp/snb_ivb_laptops/variants/8560w/hda_verb.c:

  • Patch Set #1, Line 1:

    /*
     * This file is part of the coreboot project.
     *
     * Copyright 2020 The coreboot project Authors.
     *
     * SPDX-License-Identifier: GPL-2.0-or-later
     */
    

    /* SPDX-License-Identifier: GPL-2.0-or-later */

• File src/mainboard/hp/snb_ivb_laptops/variants/8560w/overridetree.cb:

  • Patch Set #1, Line 1:

    #
    # This file is part of the coreboot project.
    #
    # Copyright 2020 The coreboot project Authors.
    #
    # SPDX-License-Identifier: GPL-2.0-or-later
    #
    

    ## SPDX-License-Identifier: GPL-2.0-or-later

  • Patch Set #1, Line 26: end

    nit: align the `end` words?

To view, visit change 39398. To unsubscribe, or for help writing mail filters, visit settings.