Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32673 )
Change subject: mb/apple: Add MacBook Pro 10,1 (A1398) support ......................................................................
Patch Set 25:
(4 comments)
https://review.coreboot.org/c/coreboot/+/32673/25/Documentation/mainboard/ap... File Documentation/mainboard/apple/mbp101_board.jpg:
PS25: Is this picture yours? I would try bringing its size down to 50 KiB
https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/cmos.default:
https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... PS25, Line 3: gfx_uma_size=32M
https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32673/25/src/mainboard/apple/macboo... PS25, Line 38: device pci 01.2 on Would be good to check what is wired to these PCIe RPs
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... File src/mainboard/apple/macbookpro10_1/mainboard.c:
https://review.coreboot.org/c/coreboot/+/32673/22/src/mainboard/apple/macboo... PS22, Line 30: LVDS
Well, VBIOS works. Who knows, maybe someone will use it.
Ack. Still, this shouldn't be LVDS but eDP