Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47707 )
Change subject: mb/intel/ehlcrb: Add initial mainboard code ......................................................................
Patch Set 6:
(6 comments)
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... File src/mainboard/intel/elkhartlake_crb/variants/ehlcrb/gpio.c:
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... PS6, Line 17: const struct pad_config *variant_gpio_table(size_t *num) Maybe `configure_gpios()` then?
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... PS6, Line 20: return gpio_table; Why not just using `gpio_configure_pads(pads, num)` here? So you don't have to move data around
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... PS6, Line 23: const struct pad_config *variant_early_gpio_table(size_t *num) `configure_early_gpios()`?
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... PS6, Line 26: return early_gpio_table; Same here
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... PS6, Line 33: const struct cros_gpio *variant_cros_gpios(size_t *num) `configure_cros_gpios()`?
https://review.coreboot.org/c/coreboot/+/47707/6/src/mainboard/intel/elkhart... PS6, Line 36: return cros_gpios; Same here