Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41111 )
Change subject: sb/intel/bd82x6x: Put temp BAR in a define
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41111/1/src/southbridge/intel/bd82x...
File src/southbridge/intel/bd82x6x/early_thermal.c:
https://review.coreboot.org/c/coreboot/+/41111/1/src/southbridge/intel/bd82x...
PS1, Line 25: value
"address"?
I wanted to avoid "Base Address Range address". I reworded the thing a bit
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41111
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icda6e4100d954fe28d2624270b5d7ab7ed155e32
Gerrit-Change-Number: 41111
Gerrit-PatchSet: 2
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-Comment-Date: Thu, 07 May 2020 10:25:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Georgi
pgeorgi@google.com
Gerrit-MessageType: comment