John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )
Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/madoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede...
PS2, Line 62: 95C
Is it 95C or 100C?
Tcc temperature setting is 95C.
https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede...
PS2, Line 76: 20000
Is it 6000 or 20000?
We have only one setting for PL2, both min and max is 20W.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45784
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4f61eaa7eab2b86b04ff0541886621afb3082b1a
Gerrit-Change-Number: 45784
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-Reviewer: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 08 Oct 2020 01:27:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment