Change in coreboot[master]: mb/google/dedede/var/madoo: Update DPTF setting

[John Su (Code Review)]

John Su has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

mb/google/dedede/var/madoo: Update DPTF setting

Add tcc, critical, passive policy, and pl values from thermal team.

BUG=b:169215576
TEST=build and verify by thermal tool

Signed-off-by: John Su 
Change-Id: I4f61eaa7eab2b86b04ff0541886621afb3082b1a
---
M src/mainboard/google/dedede/variants/madoo/overridetree.cb
1 file changed, 29 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/45784/1

diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb
index 039fd10..e73a728 100644
--- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb
@@ -53,7 +53,36 @@
                         },
    	},
    }"
+
+	register "power_limits_config" = "{
+			.tdp_pl1_override = 6,
+			.tdp_pl2_override = 20,
+	}"
+
+	register "tcc_offset" = "5"    # TCC of 95C
+
    device domain 0 on
+		device pci 04.0 on
+			chip drivers/intel/dptf
+
+				register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU    ,           65, 1000)"
+				register "policies.critical[0]" = "DPTF_CRITICAL(CPU,               100, SHUTDOWN)"
+				register "controls.power_limits.pl1" = "{
+						.min_power = 4800,
+						.max_power = 6000,
+						.time_window_min = 1 * MSECS_PER_SEC,
+						.time_window_max = 1 * MSECS_PER_SEC,
+						.granularity = 200,}"
+				register "controls.power_limits.pl2" = "{
+						.min_power = 20000,
+						.max_power = 20000,
+						.time_window_min = 1 * MSECS_PER_SEC,
+						.time_window_max = 1 * MSECS_PER_SEC,
+						.granularity = 1000,}"
+
+				device generic 0 on end
+			end
+		end # SA Thermal device
    	device pci 14.0 on
    		chip drivers/usb/acpi
    			device usb 0.0 on

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 1: Code-Review+1

[John Su (Code Review)]

Hello Frank Wu, build bot (Jenkins), Alan Lee, Dtrain Hsu, Ian Feng, Justin TerAvest, Marco Chen, Ivy Jian, EricR Lai, Karthik Ramasubramanian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/45784

to look at the new patch set (#2).

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

mb/google/dedede/var/madoo: Update DPTF setting

Add tcc, critical, passive policy, and pl values from thermal team.

BUG=b:169215576
TEST=build and verify by thermal tool

Signed-off-by: John Su 
Change-Id: I4f61eaa7eab2b86b04ff0541886621afb3082b1a
---
M src/mainboard/google/dedede/variants/madoo/overridetree.cb
1 file changed, 27 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/84/45784/2

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 2: Code-Review+1

Hi Google

Could you help to review?

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 2:

Hi Marco & Henry

Could you help to review this CL?

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/madoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
PS2, Line 62: 95C
Is it 95C or 100C?

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
PS2, Line 76: 20000
Is it 6000 or 20000?

[John Su (Code Review)]

John Su has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/madoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
PS2, Line 62: 95C
> Is it 95C or 100C?

Tcc temperature setting is 95C.

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
PS2, Line 76: 20000
> Is it 6000 or 20000?

We have only one setting for PL2, both min and max is 20W.

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 2: Code-Review+2

(2 comments)

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
File src/mainboard/google/dedede/variants/madoo/overridetree.cb:

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
PS2, Line 62: 95C
> Tcc temperature setting is 95C.

Done

https://review.coreboot.org/c/coreboot/+/45784/2/src/mainboard/google/dedede... 
PS2, Line 76: 20000
> We have only one setting for PL2, both min and max is 20W.

Done

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 2: Code-Review+2

[Sumeet R Pawnikar (Code Review)]

Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

Patch Set 2: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45784 )

Change subject: mb/google/dedede/var/madoo: Update DPTF setting
......................................................................

mb/google/dedede/var/madoo: Update DPTF setting

Add tcc, critical, passive policy, and pl values from thermal team.

BUG=b:169215576
TEST=build and verify by thermal tool

Signed-off-by: John Su 
Change-Id: I4f61eaa7eab2b86b04ff0541886621afb3082b1a
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45784
Tested-by: build bot (Jenkins) 
Reviewed-by: Karthik Ramasubramanian 
Reviewed-by: EricR Lai 
Reviewed-by: Sumeet R Pawnikar 
---
M src/mainboard/google/dedede/variants/madoo/overridetree.cb
1 file changed, 27 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Sumeet R Pawnikar: Looks good to me, approved
  John Su: Looks good to me, but someone else must approve
  Karthik Ramasubramanian: Looks good to me, approved
  EricR Lai: Looks good to me, approved

diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb
index 257f917..c284f7a 100644
--- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb
+++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb
@@ -53,7 +53,34 @@
                         },
    	},
    }"
+
+	register "power_limits_config" = "{
+			.tdp_pl1_override = 6,
+			.tdp_pl2_override = 20,
+	}"
+
+	register "tcc_offset" = "5"    # TCC of 95C
+
    device domain 0 on
+		device pci 04.0 on
+			chip drivers/intel/dptf
+				register "policies.passive[0]" = "DPTF_PASSIVE(CPU, CPU, 65, 1000)"
+				register "policies.critical[0]" = "DPTF_CRITICAL(CPU, 100, SHUTDOWN)"
+				register "controls.power_limits.pl1" = "{
+						.min_power = 4800,
+						.max_power = 6000,
+						.time_window_min = 1 * MSECS_PER_SEC,
+						.time_window_max = 1 * MSECS_PER_SEC,
+						.granularity = 200,}"
+				register "controls.power_limits.pl2" = "{
+						.min_power = 20000,
+						.max_power = 20000,
+						.time_window_min = 1 * MSECS_PER_SEC,
+						.time_window_max = 1 * MSECS_PER_SEC,
+						.granularity = 1000,}"
+				device generic 0 on end
+			end
+		end # SA Thermal device
    	device pci 14.0 on
    		chip drivers/usb/acpi
    			device usb 0.0 on