Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35757 )
Change subject: sb/intel/ibexpeak: Fix enabling HPTC ......................................................................
Patch Set 2:
(2 comments)
Patch Set 2:
(2 comments)
Is the problem also visible in the OS? Should SeaBIOS (or payloads in general) also be fixed somehow to work around firmware bugs?
Linux works around/fixes this in arch/x86/kernel/quirks.c (see ich_force_enable_hpet). SeaBIOS might be fixed but as payloads should be as platform independent as possible, it makes sense to fix in the hardware init, coreboot in this case.
https://review.coreboot.org/c/coreboot/+/35757/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35757/2//COMMIT_MSG@9 PS2, Line 9: RCBA_HPTC needs to be read back to properly work. : This fixes SeaBIOS endlessly waiting for input instead of booting the : default entry.
Please do not break the line, just because the sentence ends there. […]
Ack
https://review.coreboot.org/c/coreboot/+/35757/2/src/southbridge/intel/ibexp... File src/southbridge/intel/ibexpeak/lpc.c:
https://review.coreboot.org/c/coreboot/+/35757/2/src/southbridge/intel/ibexp... PS2, Line 397: RCBA32(HPTC); /* Read back for it to work */
Mention SeaBIOS as an exapmle?
It applies to everything that uses HPET.