Patch Set 2:

(2 comments)

Is the problem also visible in the OS? Should SeaBIOS (or payloads in general) also be fixed somehow to work around firmware bugs?

Linux works around/fixes this in arch/x86/kernel/quirks.c (see ich_force_enable_hpet). SeaBIOS might be fixed but as payloads should be as platform independent as possible, it makes sense to fix in the hardware init, coreboot in this case.

View Change

2 comments:

• Commit Message:

  • Patch Set #2, Line 9:

    RCBA_HPTC needs to be read back to properly work.
    This fixes SeaBIOS endlessly waiting for input instead of booting the
    default entry.
    

    Please do not break the line, just because the sentence ends there. […]

    Ack

• File src/southbridge/intel/ibexpeak/lpc.c:

  • Patch Set #2, Line 397: RCBA32(HPTC); /* Read back for it to work */

    Mention SeaBIOS as an exapmle?

    It applies to everything that uses HPET.

To view, visit change 35757. To unsubscribe, or for help writing mail filters, visit settings.