Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33250 )
Change subject: src/superio/aspeed/common: Add ACPI Template for Autogen Feature ......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/33250/12//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33250/12//COMMIT_MSG@7 PS12, Line 7: src/superio/aspeed/common: Add ACPI Template for Autogen Feature Please remove `src` at the beginning. The description also not very understandable in my opinion.
superio/aspeed: Add ACPI declarations
With the minimal ASL file, coreboot will autogenerate the necessary ACPI entries(?).
Please also add how you tested this.
https://review.coreboot.org/c/coreboot/+/33250/12/src/superio/aspeed/common/... File src/superio/aspeed/common/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/33250/12/src/superio/aspeed/common/... PS12, Line 18: Name (_HID, EisaId ("PNP0C02") ) // _HID: Hardware ID That’s the ID for the environment controller?