Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37449 )
Change subject: sb/amd/cimx/sb800: Postpone Sb_Poweron_Init() call ......................................................................
Patch Set 5:
(1 comment)
Patch Set 4:
I would prefer if we do not need to pull this call into bootblock, but could put this into platform_BeforeInitReset() instead.
I see
https://review.coreboot.org/c/coreboot/+/37449/5/src/northbridge/amd/agesa/f... File src/northbridge/amd/agesa/family14/state_machine.c:
https://review.coreboot.org/c/coreboot/+/37449/5/src/northbridge/amd/agesa/f... PS5, Line 52: sb_Poweron_Init(); sb_Poweron_Init is still called in board_BeforeAgesa for each mainboard making it a doubled call.
Additionally, I think the sb_Poweron_Init can be moved to the IF statement above so you could avoid calling boot_cpu() again.