Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46265 )
Change subject: mb/intel/adlrvp: Add ADL-P ramstage mainboard code
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46265/5/src/mainboard/intel/adlrvp/...
File src/mainboard/intel/adlrvp/variants/adlrvp_p/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/46265/5/src/mainboard/intel/adlrvp/...
PS5, Line 91: s0ix_enable
Alright. I wanted to know because S0ix entry requirements are somewhat unclear.
Yes, you are right, its not just depends in this config there are other SOC related FW also and HW IP might also block S0ix but this is basic to have required ACPI and C-states getting exposed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46265
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I120885956c88babfa09d24ce1079d49306919b8a
Gerrit-Change-Number: 46265
Gerrit-PatchSet: 6
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 12 Oct 2020 12:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment