Benjamin Doron has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 39:
(6 comments)
https://review.coreboot.org/c/coreboot/+/35523/20//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35523/20//COMMIT_MSG@12 PS20, Line 12: -Some amount of booting
With TianoCore as the payload, the last line of the log is "jumping to bootcode at... […]
Done
https://review.coreboot.org/c/coreboot/+/35523/20//COMMIT_MSG@15 PS20, Line 15: Assumed working:
I haven't successfully booted into an OS yet, so while the console log says that it loaded the verb […]
Done
https://review.coreboot.org/c/coreboot/+/35523/14/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/14/src/mainboard/acer/aspire_... PS14, Line 51: config CPU_MICROCODE_CBFS_LEN
Is this the length of one microcode or the whole blob? How likely is it to change in the future?
Apparently only necessary for FSP-T.
https://review.coreboot.org/c/coreboot/+/35523/14/src/mainboard/acer/aspire_... PS14, Line 59: config CBFS_SIZE
Assuming that CBFS can be $flash_size - ($intel_descriptor + $intel_ME), this is now correct. […]
Corrected now.
https://review.coreboot.org/c/coreboot/+/35523/24/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/Kconfig:
https://review.coreboot.org/c/coreboot/+/35523/24/src/mainboard/acer/aspire_... PS24, Line 18: select NO_POST # This platform has no way to see POST codes so disable them by default.
I've switched my copy to the "config NO_POST" method and I'll change it here after those boards get […]
Done
https://review.coreboot.org/c/coreboot/+/35523/13/src/mainboard/acer/aspire_... File src/mainboard/acer/aspire_vn7_572g/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35523/13/src/mainboard/acer/aspire_... PS13, Line 80: # VR Settings Configuration for 4 Domains
OEM BIOS seems to literally disable VR config. Also guessing that it uses FSP 1.1, it has 5 domains.
VR config has now been set appropriately for SKL-U