Attention is currently required from: Mac Mini, Evgeny Zinoviev. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49074 ) Change subject: Apple Mac Mini (mid 2011) ...................................................................... Patch Set 1: (11 comments) File src/mainboard/apple/macmini5_1/Kconfig: https://review.coreboot.org/c/coreboot/+/49074/comment/030c14fc_4857c5cf PS1, Line 25: config VGA_BIOS_FILE : string : default "pci8086,0126.rom" : : config VGA_BIOS_ID : string : default "8086,0126" Please remove, not all CPUs will use the same IDs https://review.coreboot.org/c/coreboot/+/49074/comment/c92a3fa2_cf2fe47a PS1, Line 33: config DRAM_RESET_GATE_GPIO : int : default 30 Impossible. GPIO is configured as input. Does S3 suspend/resume work? File src/mainboard/apple/macmini5_1/Kconfig.name: https://review.coreboot.org/c/coreboot/+/49074/comment/e2bed419_4f291b15 PS1, Line 2: bool "Macmini5,1" I would also add the mainboard model between parentheses: `(820-3017-A)` File src/mainboard/apple/macmini5_1/acpi_tables.c: https://review.coreboot.org/c/coreboot/+/49074/comment/23495ca5_f9565ecf PS1, Line 6: void acpi_create_gnvs(struct global_nvs *gnvs) : { : /* Temperature at which OS will shutdown */ : gnvs->tcrt = 100; : /* Temperature at which OS will throttle CPU */ : gnvs->tpsv = 90; : } Isn't used anywhere File src/mainboard/apple/macmini5_1/devicetree.cb: https://review.coreboot.org/c/coreboot/+/49074/comment/70e283d0_aeb5a612 PS1, Line 15: 0x8086 0x7270 Replace with `0x106b 0x0e6` and drop all other subsystem ID entries https://review.coreboot.org/c/coreboot/+/49074/comment/161bd3d3_2a8033ba PS1, Line 29: ??
? Interesting... This device shouldn't appear. Keeping it off should be fine.
https://review.coreboot.org/c/coreboot/+/49074/comment/fc482ceb_d92678b4 PS1, Line 52: device pci 1a.7 on end
What's this? It could only appear if Apple firmware didn't enable the RMH (Rate-Matching Hub), if that's even possible on bd82x6x. coreboot always enables the RMH, so this can be dropped.
https://review.coreboot.org/c/coreboot/+/49074/comment/786e8761_a6928e4d PS1, Line 66: device pci 1d.7 on end Drop this too File src/mainboard/apple/macmini5_1/dsdt.asl: https://review.coreboot.org/c/coreboot/+/49074/comment/395d796a_a82c9a86 PS1, Line 3: #define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB : #define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB No brightness to control https://review.coreboot.org/c/coreboot/+/49074/comment/be8f61c4_2a1225ee PS1, Line 27: #include <drivers/intel/gma/acpi/default_brightness_levels.asl> No brightness to control. File src/mainboard/apple/macmini5_1/early_init.c: https://review.coreboot.org/c/coreboot/+/49074/comment/b3c02451_cdfea1c3 PS1, Line 28: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f); : pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0070); These register writes can be dropped (the function can be dropped too) -- To view, visit https://review.coreboot.org/c/coreboot/+/49074 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ied578e8a9c7ff2c041b5495491acb256019f1c6d Gerrit-Change-Number: 49074 Gerrit-PatchSet: 1 Gerrit-Owner: Mac Mini <mac-mini-2011@outlook.com> Gerrit-Reviewer: Evgeny Zinoviev <me@ch1p.io> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Angel Pons <th3fanbus@gmail.com> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Attention: Mac Mini <mac-mini-2011@outlook.com> Gerrit-Attention: Evgeny Zinoviev <me@ch1p.io> Gerrit-Comment-Date: Mon, 18 Jan 2021 22:09:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Evgeny Zinoviev <me@ch1p.io> Gerrit-MessageType: comment