Attention is currently required from: Mac Mini, Evgeny Zinoviev.
11 comments:
File src/mainboard/apple/macmini5_1/Kconfig:
config VGA_BIOS_FILE
string
default "pci8086,0126.rom"
config VGA_BIOS_ID
string
default "8086,0126"
Please remove, not all CPUs will use the same IDs
config DRAM_RESET_GATE_GPIO
int
default 30
Impossible. GPIO is configured as input. Does S3 suspend/resume work?
File src/mainboard/apple/macmini5_1/Kconfig.name:
Patch Set #1, Line 2: bool "Macmini5,1"
I would also add the mainboard model between parentheses: `(820-3017-A)`
File src/mainboard/apple/macmini5_1/acpi_tables.c:
void acpi_create_gnvs(struct global_nvs *gnvs)
{
/* Temperature at which OS will shutdown */
gnvs->tcrt = 100;
/* Temperature at which OS will throttle CPU */
gnvs->tpsv = 90;
}
Isn't used anywhere
File src/mainboard/apple/macmini5_1/devicetree.cb:
Patch Set #1, Line 15: 0x8086 0x7270
Replace with `0x106b 0x0e6` and drop all other subsystem ID entries
?
Interesting... This device shouldn't appear. Keeping it off should be fine.
Patch Set #1, Line 52: device pci 1a.7 on end
What's this?
It could only appear if Apple firmware didn't enable the RMH (Rate-Matching Hub), if that's even possible on bd82x6x. coreboot always enables the RMH, so this can be dropped.
Patch Set #1, Line 66: device pci 1d.7 on end
Drop this too
File src/mainboard/apple/macmini5_1/dsdt.asl:
#define BRIGHTNESS_UP \_SB.PCI0.GFX0.INCB
#define BRIGHTNESS_DOWN \_SB.PCI0.GFX0.DECB
No brightness to control
Patch Set #1, Line 27: #include <drivers/intel/gma/acpi/default_brightness_levels.asl>
No brightness to control.
File src/mainboard/apple/macmini5_1/early_init.c:
pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x3f0f);
pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0070);
These register writes can be dropped (the function can be dropped too)
To view, visit change 49074. To unsubscribe, or for help writing mail filters, visit settings.