Attention is currently required from: Angel Pons, Felix Held.
Evgeny Zinoviev has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32604 )
Change subject: mb/apple: Add MacBook Air 5,2 (A1466) support ......................................................................
Patch Set 37:
(11 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/32604/comment/0c3bad68_58b4f5ce PS36, Line 38: - Thunderbolt : The thunderbolt-to-ethernet adapter is detected by the kernel: : [ 835.495393] thunderbolt 0-1: new device found, vendor=0x1 : device=0x8003 : [ 835.495408] thunderbolt 0-1: Apple, Inc. Thunderbolt to Gigabit : Ethernet Adapter : The network interface wasn't created though, so I couldn't test the : adapter. No idea if it's linux or coreboot, but I think it's linux issue.
Was the Thunderbolt-to-Ethernet adapter plugged in before booting, or was it plugged in afterwards? […]
Afterwards.
File Documentation/mainboard/apple/macbookair5_2.md:
https://review.coreboot.org/c/coreboot/+/32604/comment/2655e195_009eee46 PS36, Line 139: usb
USB
Done
File src/mainboard/apple/macbookair5_2/Kconfig:
https://review.coreboot.org/c/coreboot/+/32604/comment/1735cb45_650b00a4 PS36, Line 27: string
Type not needed
Done
File src/mainboard/apple/macbookair5_2/cmos.default:
https://review.coreboot.org/c/coreboot/+/32604/comment/f4d33b38_16e3ecf9 PS36, Line 3: 32M
I think macOS wants at least 64M here
I don't know what macOS wants but corebooting a macbook to then turn it into a hackintosh to use macOS on it sounds a bit silly anyway. :)
But sure, why not.
File src/mainboard/apple/macbookair5_2/cmos.layout:
https://review.coreboot.org/c/coreboot/+/32604/comment/3b972407_21d01596 PS36, Line 29: # SandyBridge MRC Scrambler Seed values : 896 32 r 0 mrc_scrambler_seed : 928 32 r 0 mrc_scrambler_seed_s3 : 960 16 r 0 mrc_scrambler_seed_chk
This is only needed when using MRC. […]
Done
https://review.coreboot.org/c/coreboot/+/32604/comment/3a51cff5_c78d78fc PS36, Line 42: 2 0 Enable : 2 1 Disable
This enumeration is unused, please drop
Done
https://review.coreboot.org/c/coreboot/+/32604/comment/6adab6ae_79febaf0 PS36, Line 58: 11 0 32M : 11 1 64M : 11 2 96M : 11 3 128M : 11 4 160M : 11 5 192M : 11 6 224M
Add all possible choices for `gfx_uma_size`: […]
Done
File src/mainboard/apple/macbookair5_2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/32604/comment/611c1727_59488384 PS36, Line 68: PCI-LPC bridge
This part of the comment is redundant, I'd drop it.
Done
File src/mainboard/apple/macbookair5_2/dsdt.asl:
https://review.coreboot.org/c/coreboot/+/32604/comment/7a7ac2a8_24e1a74f PS36, Line 10: // OEM revision
I'd drop this comment
Done
File src/mainboard/apple/macbookair5_2/early_init.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/0d7fc3ef_67062c3f PS36, Line 6: #include <southbridge/intel/common/gpio.h>
Missing: #include <types.h> […]
Done
File src/mainboard/apple/macbookair5_2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/32604/comment/46bfa453_69cffa0f PS36, Line 9: GMA_INT15_PANEL_FIT_DEFAULT, : GMA_INT15_BOOT_DISPLAY_DEFAULT, 0);
nit: Add another tab so that the arguments start on the same column
Done